This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(input): Fix input errors CSS to properly display. #6298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also fix the autocomplete issues? |
|
@michaelkrog If your issue was specific to the CSS, then this should fix it as well. However, I updated your Codepen to use my local branch and it doesn't look like the messages are even in the DOM. Can you take a quick look at your Codepen (http://codepen.io/anon/pen/yeLPVy) and see if it's missing something that you can easily fix? I'd love to test this against the Autocomplete and make sure it works. |
|
Hi @topherfangio. Something definitely changed in autocomplete. It used to be in the DOM in rc6, but broken because of CSS. Now it seems to be found nowhere i the DOM. I'll create an issue for it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a CSS property that was not restrictive enough, standard error messages were hidden by default.
Restrict CSS to components with the
md-auto-hideclass. Note that this unfortunately re-introduces the message flicker bug for messages which do not use themd-auto-hide. This should be fixed when angular/angular.js#12969 is merged and available.Also, remove the
md-maxlengthrequirement from the errors Hourly Rate demo to reduce confusion.Fixes #5837. References #5321.